From d6a62ed405a2ab8897e021ff4d07b211d40bbf45 Mon Sep 17 00:00:00 2001 From: Amin Shaikh Date: Thu, 23 Feb 2017 10:08:10 -0800 Subject: [PATCH] Fix failing WifiConfigManagerTest test. Bug: 35671673 Test: runtest frameworks-core frameworks-wifi Change-Id: I55ff41464cabfb97d03a0758d73145df808ec2c8 Merged-In: I55ff41464cabfb97d03a0758d73145df808ec2c8 --- .../android/net/wifi/WifiConfiguration.java | 1 + .../net/wifi/WifiConfigurationTest.java | 32 +++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/wifi/java/android/net/wifi/WifiConfiguration.java b/wifi/java/android/net/wifi/WifiConfiguration.java index 14deabec74674..2ba573c0cb3ac 100644 --- a/wifi/java/android/net/wifi/WifiConfiguration.java +++ b/wifi/java/android/net/wifi/WifiConfiguration.java @@ -1295,6 +1295,7 @@ public class WifiConfiguration implements Parcelable { setConnectChoice(source.getConnectChoice()); setConnectChoiceTimestamp(source.getConnectChoiceTimestamp()); setHasEverConnected(source.getHasEverConnected()); + setNotRecommended(source.isNotRecommended()); } public void writeToParcel(Parcel dest) { diff --git a/wifi/tests/src/android/net/wifi/WifiConfigurationTest.java b/wifi/tests/src/android/net/wifi/WifiConfigurationTest.java index 5f9497474a778..632cfaf2155a7 100644 --- a/wifi/tests/src/android/net/wifi/WifiConfigurationTest.java +++ b/wifi/tests/src/android/net/wifi/WifiConfigurationTest.java @@ -20,6 +20,7 @@ import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import android.os.Parcel; +import android.net.wifi.WifiConfiguration.NetworkSelectionStatus; import org.junit.Before; import org.junit.Test; @@ -66,4 +67,35 @@ public class WifiConfigurationTest { assertArrayEquals(bytes, rebytes); } + + @Test + public void testNetworkSelectionStatusCopy() { + NetworkSelectionStatus networkSelectionStatus = new NetworkSelectionStatus(); + networkSelectionStatus.setNotRecommended(true); + + NetworkSelectionStatus copy = new NetworkSelectionStatus(); + copy.copy(networkSelectionStatus); + + assertEquals(networkSelectionStatus.isNotRecommended(), copy.isNotRecommended()); + } + + @Test + public void testNetworkSelectionStatusParcel() { + NetworkSelectionStatus networkSelectionStatus = new NetworkSelectionStatus(); + networkSelectionStatus.setNotRecommended(true); + + Parcel parcelW = Parcel.obtain(); + networkSelectionStatus.writeToParcel(parcelW); + byte[] bytes = parcelW.marshall(); + parcelW.recycle(); + + Parcel parcelR = Parcel.obtain(); + parcelR.unmarshall(bytes, 0, bytes.length); + parcelR.setDataPosition(0); + + NetworkSelectionStatus copy = new NetworkSelectionStatus(); + copy.readFromParcel(parcelR); + + assertEquals(networkSelectionStatus.isNotRecommended(), copy.isNotRecommended()); + } }