From 088de9ff5a02f4713fec9a1659905806c3fa0f0d Mon Sep 17 00:00:00 2001 From: Josh Tsuji Date: Fri, 8 Oct 2021 17:34:34 -0400 Subject: [PATCH] Don't expand the keyguard if it's fading away. Bug: 196364593 Test: run an app that is locked in landscape, lock the screen, unlock it Change-Id: I2516e8d2b5b7da0056eeec0b85ed33362f7f3503 --- .../systemui/statusbar/phone/PanelViewController.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelViewController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelViewController.java index 768567b8b4741..c23577c523e36 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelViewController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelViewController.java @@ -385,11 +385,16 @@ public abstract class PanelViewController { final boolean expand; if (event.getActionMasked() == MotionEvent.ACTION_CANCEL || forceCancel) { - // If we get a cancel, put the shade back to the state it was in when the gesture - // started - if (onKeyguard) { + // If the keyguard is fading away, don't expand it again. This can happen if you're + // swiping to unlock, the app below the keyguard is in landscape, and the screen + // rotates while your finger is still down after the swipe to unlock. + if (mKeyguardStateController.isKeyguardFadingAway()) { + expand = false; + } else if (onKeyguard) { expand = true; } else { + // If we get a cancel, put the shade back to the state it was in when the + // gesture started expand = !mPanelClosedOnDown; } } else {