Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Add metrics around scheduling failures." into udc-dev

Browse Source
This commit is contained in:
Treehugger Robot
2023-05-09 16:34:47 +00:00
committed by Android (Google) Code Review
parent fbcc05a92a 30cd1ec8ab
commit 07c181c783
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apex/jobscheduler/service/java/com/android/server/job/JobSchedulerService.java
View File

@@ -1443,6 +1443,9 @@ public class JobSchedulerService extends com.android.server.SystemService
if (mActivityManagerInternal.isAppStartModeDisabled(uId, servicePkg)) { if (mActivityManagerInternal.isAppStartModeDisabled(uId, servicePkg)) {
Slog.w(TAG, "Not scheduling job " + uId + ":" + job.toString() Slog.w(TAG, "Not scheduling job " + uId + ":" + job.toString()
+ " -- package not allowed to start"); + " -- package not allowed to start");
Counter.logIncrementWithUid(
"job_scheduler.value_cntr_w_uid_schedule_failure_app_start_mode_disabled",
uId);
return JobScheduler.RESULT_FAILURE; return JobScheduler.RESULT_FAILURE;
} }
@@ -1519,6 +1522,9 @@ public class JobSchedulerService extends com.android.server.SystemService
if ((mConstants.USE_TARE_POLICY && !mTareController.canScheduleEJ(jobStatus)) if ((mConstants.USE_TARE_POLICY && !mTareController.canScheduleEJ(jobStatus))
|| (!mConstants.USE_TARE_POLICY || (!mConstants.USE_TARE_POLICY
&& !mQuotaController.isWithinEJQuotaLocked(jobStatus))) { && !mQuotaController.isWithinEJQuotaLocked(jobStatus))) {
Counter.logIncrementWithUid(
"job_scheduler.value_cntr_w_uid_schedule_failure_ej_out_of_quota",
uId);
return JobScheduler.RESULT_FAILURE; return JobScheduler.RESULT_FAILURE;
} }
} }
@@ -4083,6 +4089,9 @@ public class JobSchedulerService extends com.android.server.SystemService
if (!isInStateToScheduleUiJobSource && !isInStateToScheduleUiJobCalling) { if (!isInStateToScheduleUiJobSource && !isInStateToScheduleUiJobCalling) {
Slog.e(TAG, "Uid(s) " + sourceUid + "/" + callingUid Slog.e(TAG, "Uid(s) " + sourceUid + "/" + callingUid
+ " not in a state to schedule user-initiated jobs"); + " not in a state to schedule user-initiated jobs");
Counter.logIncrementWithUid(
"job_scheduler.value_cntr_w_uid_schedule_failure_uij_invalid_state",
callingUid);
return JobScheduler.RESULT_FAILURE; return JobScheduler.RESULT_FAILURE;
} }
} }
@@ -4136,10 +4145,14 @@ public class JobSchedulerService extends com.android.server.SystemService
private int validateRunUserInitiatedJobsPermission(int uid, String packageName) { private int validateRunUserInitiatedJobsPermission(int uid, String packageName) {
final int state = getRunUserInitiatedJobsPermissionState(uid, packageName); final int state = getRunUserInitiatedJobsPermissionState(uid, packageName);
if (state == PermissionChecker.PERMISSION_HARD_DENIED) { if (state == PermissionChecker.PERMISSION_HARD_DENIED) {
Counter.logIncrementWithUid(
"job_scheduler.value_cntr_w_uid_schedule_failure_uij_no_permission", uid);
throw new SecurityException(android.Manifest.permission.RUN_USER_INITIATED_JOBS throw new SecurityException(android.Manifest.permission.RUN_USER_INITIATED_JOBS
+ " required to schedule user-initiated jobs."); + " required to schedule user-initiated jobs.");
} }
if (state == PermissionChecker.PERMISSION_SOFT_DENIED) { if (state == PermissionChecker.PERMISSION_SOFT_DENIED) {
Counter.logIncrementWithUid(
"job_scheduler.value_cntr_w_uid_schedule_failure_uij_no_permission", uid);
return JobScheduler.RESULT_FAILURE; return JobScheduler.RESULT_FAILURE;
} }
return JobScheduler.RESULT_SUCCESS; return JobScheduler.RESULT_SUCCESS;