From 14d5a971cb1121f3fddb007fa09b43439f88386c Mon Sep 17 00:00:00 2001 From: Hyundo Moon Date: Thu, 25 Mar 2021 09:37:42 +0900 Subject: [PATCH] MediaRouter2: Add RouteDiscoveryPrefernce.EMPTY as @SystemApi This CL also removes MR2#registerRouteCallback(executor, callback). Bug: 183656331 Test: Passed CTS Change-Id: I7cbfed9dd1dd6d92e0d9d012da7aef11a397139f --- core/api/system-current.txt | 5 ++++- media/java/android/media/MediaRouter2.java | 18 ------------------ .../media/RouteDiscoveryPreference.java | 4 +++- 3 files changed, 7 insertions(+), 20 deletions(-) diff --git a/core/api/system-current.txt b/core/api/system-current.txt index a0e0f7133a257..6a860dead7364 100644 --- a/core/api/system-current.txt +++ b/core/api/system-current.txt @@ -5231,7 +5231,6 @@ package android.media { method @Nullable public String getClientPackageName(); method @Nullable public android.media.MediaRouter2.RoutingController getController(@NonNull String); method @Nullable public static android.media.MediaRouter2 getInstance(@NonNull android.content.Context, @NonNull String); - method public void registerRouteCallback(@NonNull java.util.concurrent.Executor, @NonNull android.media.MediaRouter2.RouteCallback); method public void setRouteVolume(@NonNull android.media.MediaRoute2Info, int); method public void startScan(); method public void stopScan(); @@ -5255,6 +5254,10 @@ package android.media { method @RequiresPermission(android.Manifest.permission.WRITE_SETTINGS) public static void ensureDefaultRingtones(@NonNull android.content.Context); } + public final class RouteDiscoveryPreference implements android.os.Parcelable { + field public static final android.media.RouteDiscoveryPreference EMPTY; + } + } package android.media.audiofx { diff --git a/media/java/android/media/MediaRouter2.java b/media/java/android/media/MediaRouter2.java index 8daa303890126..02fa0401e5862 100644 --- a/media/java/android/media/MediaRouter2.java +++ b/media/java/android/media/MediaRouter2.java @@ -298,24 +298,6 @@ public final class MediaRouter2 { return mClientPackageName; } - /** - * Registers a callback to receive route related events when they change. - *

- * If the specified callback is already registered, its registration will be updated for the - * given {@link Executor executor}. - *

- * This will be no-op for non-system routers. - * @hide - */ - @SystemApi - public void registerRouteCallback(@NonNull @CallbackExecutor Executor executor, - @NonNull RouteCallback routeCallback) { - if (!isSystemRouter()) { - return; - } - registerRouteCallback(executor, routeCallback, RouteDiscoveryPreference.EMPTY); - } - /** * Registers a callback to discover routes and to receive events when they change. *

diff --git a/media/java/android/media/RouteDiscoveryPreference.java b/media/java/android/media/RouteDiscoveryPreference.java index 2f952474b7f0a..37fee8466859c 100644 --- a/media/java/android/media/RouteDiscoveryPreference.java +++ b/media/java/android/media/RouteDiscoveryPreference.java @@ -18,6 +18,7 @@ package android.media; import android.annotation.NonNull; import android.annotation.Nullable; +import android.annotation.SystemApi; import android.os.Bundle; import android.os.Parcel; import android.os.Parcelable; @@ -68,9 +69,10 @@ public final class RouteDiscoveryPreference implements Parcelable { private final Bundle mExtras; /** - * An empty discovery preference + * An empty discovery preference. * @hide */ + @SystemApi public static final RouteDiscoveryPreference EMPTY = new Builder(Collections.emptyList(), false).build();