From ba7564dafa97c537742d201a7ebe5ad013789eb4 Mon Sep 17 00:00:00 2001 From: Alison Cichowlas Date: Tue, 1 May 2018 09:56:37 -0400 Subject: [PATCH] Remove ticker text for screenshot saving notification. Info here is duplicated in the context text, and was read twice for a11y. Test: Manual, with TalkBack - trigger several SS notifications. Bug: 77585533 Change-Id: I369c749df3030536f7118661262228d1882ab1b8 --- .../android/systemui/screenshot/GlobalScreenshot.java | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/screenshot/GlobalScreenshot.java b/packages/SystemUI/src/com/android/systemui/screenshot/GlobalScreenshot.java index 227f2d2be0a98..8a0d7e38f8757 100644 --- a/packages/SystemUI/src/com/android/systemui/screenshot/GlobalScreenshot.java +++ b/packages/SystemUI/src/com/android/systemui/screenshot/GlobalScreenshot.java @@ -129,13 +129,6 @@ class SaveImageInBackgroundTask extends AsyncTask { private final int mImageWidth; private final int mImageHeight; - // WORKAROUND: We want the same notification across screenshots that we update so that we don't - // spam a user's notification drawer. However, we only show the ticker for the saving state - // and if the ticker text is the same as the previous notification, then it will not show. So - // for now, we just add and remove a space from the ticker text to trigger the animation when - // necessary. - private static boolean mTickerAddSpace; - SaveImageInBackgroundTask(Context context, SaveImageInBackgroundData data, NotificationManager nManager) { Resources r = context.getResources(); @@ -176,8 +169,6 @@ class SaveImageInBackgroundTask extends AsyncTask { Bitmap icon = generateAdjustedHwBitmap(data.image, iconSize, iconSize, matrix, paint, overlayColor); - // Show the intermediate notification - mTickerAddSpace = !mTickerAddSpace; mNotificationManager = nManager; final long now = System.currentTimeMillis(); @@ -199,8 +190,6 @@ class SaveImageInBackgroundTask extends AsyncTask { mNotificationBuilder = new Notification.Builder(context, NotificationChannels.SCREENSHOTS_HEADSUP) - .setTicker(r.getString(R.string.screenshot_saving_ticker) - + (mTickerAddSpace ? " " : "")) .setContentTitle(r.getString(R.string.screenshot_saving_title)) .setSmallIcon(R.drawable.stat_notify_image) .setWhen(now)