From 6157de0e2d87568d6d5071b11aeb033a7986b279 Mon Sep 17 00:00:00 2001 From: Chih-Chung Chang Date: Thu, 24 Sep 2009 15:29:35 -0700 Subject: [PATCH] Fix 2101425: Camera crashes spontaneously in preview. The problem is we missed an "obj" parameter while calling postEventFromNative (which put it in a field of a Message object), so a garbage value on stack is used. When the GC tries to follow that "obj" field, expecting to find another object, it crashes. --- core/jni/android_hardware_Camera.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/jni/android_hardware_Camera.cpp b/core/jni/android_hardware_Camera.cpp index 6b9299454a9fd..e944654a2fb31 100644 --- a/core/jni/android_hardware_Camera.cpp +++ b/core/jni/android_hardware_Camera.cpp @@ -112,7 +112,7 @@ void JNICameraContext::notify(int32_t msgType, int32_t ext1, int32_t ext2) } JNIEnv *env = AndroidRuntime::getJNIEnv(); env->CallStaticVoidMethod(mCameraJClass, fields.post_event, - mCameraJObjectWeak, msgType, ext1, ext2); + mCameraJObjectWeak, msgType, ext1, ext2, NULL); } void JNICameraContext::copyAndPost(JNIEnv* env, const sp& dataPtr, int msgType)