From 060677f4686a93d92117d7d472e754423a368bdb Mon Sep 17 00:00:00 2001 From: satok Date: Thu, 17 Nov 2011 09:40:56 +0900 Subject: [PATCH] Clean up the spell checker framework Change-Id: I64c0d813e53a4ebf8d7e63463e36f6900f1aa7d3 --- core/java/android/view/textservice/SpellCheckerSession.java | 3 ++- .../java/com/android/server/TextServicesManagerService.java | 6 ++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/core/java/android/view/textservice/SpellCheckerSession.java b/core/java/android/view/textservice/SpellCheckerSession.java index 0eb6e27f5d296..489587ed36d15 100644 --- a/core/java/android/view/textservice/SpellCheckerSession.java +++ b/core/java/android/view/textservice/SpellCheckerSession.java @@ -201,7 +201,7 @@ public class SpellCheckerSession { private static final int TASK_CLOSE = 3; private final Queue mPendingTasks = new LinkedList(); - private final Handler mHandler; + private Handler mHandler; private boolean mOpened; private ISpellCheckerSession mISpellCheckerSession; @@ -334,6 +334,7 @@ public class SpellCheckerSession { try { mISpellCheckerSession.onClose(); mISpellCheckerSession = null; + mHandler = null; } catch (RemoteException e) { Log.e(TAG, "Failed to close " + e); } diff --git a/services/java/com/android/server/TextServicesManagerService.java b/services/java/com/android/server/TextServicesManagerService.java index af9152df84e5d..d04b4404ae40a 100644 --- a/services/java/com/android/server/TextServicesManagerService.java +++ b/services/java/com/android/server/TextServicesManagerService.java @@ -360,7 +360,7 @@ public class TextServicesManagerService extends ITextServicesManager.Stub { } final String sciId = info.getId(); final InternalServiceConnection connection = new InternalServiceConnection( - sciId, locale, scListener, bundle); + sciId, locale, bundle); final Intent serviceIntent = new Intent(SpellCheckerService.SERVICE_INTERFACE); serviceIntent.setComponent(info.getComponent()); if (DBG) { @@ -704,15 +704,13 @@ public class TextServicesManagerService extends ITextServicesManager.Stub { } private class InternalServiceConnection implements ServiceConnection { - private final ISpellCheckerSessionListener mListener; private final String mSciId; private final String mLocale; private final Bundle mBundle; public InternalServiceConnection( - String id, String locale, ISpellCheckerSessionListener listener, Bundle bundle) { + String id, String locale, Bundle bundle) { mSciId = id; mLocale = locale; - mListener = listener; mBundle = bundle; }