From 05d740b7d6eb99e039814b4260df932a7be09115 Mon Sep 17 00:00:00 2001 From: Victor Chang Date: Mon, 10 Oct 2022 20:11:58 +0100 Subject: [PATCH] Don't use Parameterized runner in StringBuilderPerfTest Using Parameterized runner has a problem in the test report, and doesn't report the average time of the runs. Test: atest CorePerfTests:android.libcore.regression.StringBuilderPerfTest Change-Id: Ic96b87435cc047fd3620851cfb48f6e4655adb36 --- .../regression/StringBuilderPerfTest.java | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/apct-tests/perftests/core/src/android/libcore/regression/StringBuilderPerfTest.java b/apct-tests/perftests/core/src/android/libcore/regression/StringBuilderPerfTest.java index 34fb88bf86275..10fa8b93acaf2 100644 --- a/apct-tests/perftests/core/src/android/libcore/regression/StringBuilderPerfTest.java +++ b/apct-tests/perftests/core/src/android/libcore/regression/StringBuilderPerfTest.java @@ -20,28 +20,19 @@ import android.perftests.utils.BenchmarkState; import android.perftests.utils.PerfStatusReporter; import android.test.suitebuilder.annotation.LargeTest; +import androidx.test.runner.AndroidJUnit4; + import org.junit.Rule; import org.junit.Test; import org.junit.runner.RunWith; -import org.junit.runners.Parameterized; -import org.junit.runners.Parameterized.Parameters; - -import java.util.Arrays; -import java.util.Collection; /** Tests the performance of various StringBuilder methods. */ -@RunWith(Parameterized.class) +@RunWith(AndroidJUnit4.class) @LargeTest public class StringBuilderPerfTest { @Rule public PerfStatusReporter mPerfStatusReporter = new PerfStatusReporter(); - @Parameters(name = "mLength={0}") - public static Collection data() { - return Arrays.asList(new Object[][] {{1}, {10}, {100}}); - } - - @Parameterized.Parameter(0) - public int mLength; + public int mLength = 100; @Test public void timeAppendBoolean() {