From 0a082e2c38530686498c44137d7f4cf76ac57074 Mon Sep 17 00:00:00 2001 From: Lorenzo Colitti Date: Mon, 25 Apr 2016 22:48:26 +0900 Subject: [PATCH] When dumping connectivity metrics events, print data as well. Currently the output is not very interesting, looking like: ConnectivityMetricsEvent(1461591945223, 4, 5): Bundle[mParcelledData.dataSize=340] ConnectivityMetricsEvent(1461591945289, 0, 2048): android.net.metrics.NetworkEvent@b76cd61 ConnectivityMetricsEvent(1461591945296, 4, 5): Bundle[mParcelledData.dataSize=340] ConnectivityMetricsEvent(1461591945299, 0, 3072): android.net.metrics.DefaultNetworkEvent@e2f3086 ConnectivityMetricsEvent(1461591945527, 0, 2051): android.net.metrics.ValidationProbeEvent@884ad47 but at least it's better than nothing, and event logger users can always implement a better toString method on their events. This is only enabled if --events is passed into the dump. Bug: 28204408 Change-Id: Ife96b8d54e5e91317d86b622d5efc29724969f63 --- core/java/android/net/ConnectivityMetricsEvent.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/java/android/net/ConnectivityMetricsEvent.java b/core/java/android/net/ConnectivityMetricsEvent.java index 5153ba903ecf6..71ba65f0d3311 100644 --- a/core/java/android/net/ConnectivityMetricsEvent.java +++ b/core/java/android/net/ConnectivityMetricsEvent.java @@ -77,8 +77,8 @@ public final class ConnectivityMetricsEvent implements Parcelable { } public String toString() { - return String.format("ConnectivityMetricsEvent(%d, %d, %d)", timestamp, - componentTag, eventTag); + return String.format("ConnectivityMetricsEvent(%d, %d, %d): %s", timestamp, + componentTag, eventTag, data); } /** {@hide} */