From a08d2c2ee72775afdc9892cdc114902bd174f96d Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Thu, 20 Dec 2018 13:39:40 -0800 Subject: [PATCH] Fix/suppress bootanimation google-explicit-constructor warnings * Add explicit to conversion constructors/operators Bug: 28341362 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor Change-Id: Ia6ada49250973d507ae8b10d8f0d7c2d47ee805c --- cmds/bootanimation/BootAnimation.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds/bootanimation/BootAnimation.h b/cmds/bootanimation/BootAnimation.h index b4699d8846815..4fd5c0ef5f28f 100644 --- a/cmds/bootanimation/BootAnimation.h +++ b/cmds/bootanimation/BootAnimation.h @@ -113,7 +113,7 @@ public: virtual void shutdown() {} }; - BootAnimation(sp callbacks); + explicit BootAnimation(sp callbacks); sp session() const; @@ -127,7 +127,7 @@ private: class TimeCheckThread : public Thread { public: - TimeCheckThread(BootAnimation* bootAnimation); + explicit TimeCheckThread(BootAnimation* bootAnimation); virtual ~TimeCheckThread(); private: virtual status_t readyToRun();