From ffebeff242cbdc4cc4cef5b3c8c2f3945dc8f3f4 Mon Sep 17 00:00:00 2001 From: Nataniel Borges Date: Fri, 14 Apr 2023 09:57:55 +0000 Subject: [PATCH] Promote passing OpenAppFromLockNotificationCold tests It's <1% flaky in presubmit for the past month Bug: 203538234 Test: atest FlickerTests Change-Id: I5988bb21d28be5fa99f91c3d9c26fe7432654bf9 --- .../launch/OpenAppFromLockNotificationCold.kt | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromLockNotificationCold.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromLockNotificationCold.kt index 12c08748cbac6..862efbd6a897e 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromLockNotificationCold.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromLockNotificationCold.kt @@ -16,12 +16,9 @@ package com.android.server.wm.flicker.launch -import android.platform.test.annotations.FlakyTest import android.platform.test.annotations.Postsubmit -import android.platform.test.annotations.Presubmit import android.platform.test.rule.SettingOverrideRule import android.provider.Settings -import android.tools.common.datatypes.component.ComponentNameMatcher import android.tools.device.flicker.junit.FlickerParametersRunnerFactory import android.tools.device.flicker.legacy.FlickerBuilder import android.tools.device.flicker.legacy.FlickerTest @@ -67,12 +64,6 @@ open class OpenAppFromLockNotificationCold(flicker: FlickerTest) : } } - /** {@inheritDoc} */ - @FlakyTest(bugId = 203538234) - @Test - override fun visibleWindowsShownMoreThanOneConsecutiveEntry() = - super.visibleWindowsShownMoreThanOneConsecutiveEntry() - /** {@inheritDoc} */ @Test @Ignore("Display is off at the start") override fun navBarLayerPositionAtStartAndEnd() {} @@ -97,14 +88,6 @@ open class OpenAppFromLockNotificationCold(flicker: FlickerTest) : @Ignore("Not applicable to this CUJ. Display starts locked and app is full screen at the end") override fun navBarWindowIsVisibleAtStartAndEnd() = super.navBarWindowIsVisibleAtStartAndEnd() - /** - * Checks the position of the [ComponentNameMatcher.STATUS_BAR] at the start and end of the - * transition - */ - @Presubmit - @Test - override fun statusBarLayerPositionAtEnd() = super.statusBarLayerPositionAtEnd() - /** {@inheritDoc} */ @Test @Ignore("Not applicable to this CUJ. Display starts locked and app is full screen at the end") @@ -143,7 +126,7 @@ open class OpenAppFromLockNotificationCold(flicker: FlickerTest) : val disableUnseenNotifFilterRule = SettingOverrideRule( Settings.Secure.LOCK_SCREEN_SHOW_ONLY_UNSEEN_NOTIFICATIONS, - /* value= */ "0", + /* value = */ "0", ) } }