From 04820a5e65dda9c9e771f5bd5bae4c7ebeeaaa02 Mon Sep 17 00:00:00 2001 From: Adam He Date: Wed, 10 Apr 2019 12:25:55 -0700 Subject: [PATCH] Sets vulture to null to prevent crashes caused by unlinkToDeath. Fixes: 130215863 Bug: 129250887 Test: manual verification Change-Id: I62e8f742869967b6a4e1f56aa82f3e17ae99b16f --- services/autofill/java/com/android/server/autofill/Session.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/services/autofill/java/com/android/server/autofill/Session.java b/services/autofill/java/com/android/server/autofill/Session.java index 0402b8fb92859..afb8a15bd24d3 100644 --- a/services/autofill/java/com/android/server/autofill/Session.java +++ b/services/autofill/java/com/android/server/autofill/Session.java @@ -704,6 +704,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState mClient.asBinder().linkToDeath(mClientVulture, 0); } catch (RemoteException e) { Slog.w(TAG, "could not set binder death listener on autofill client: " + e); + mClientVulture = null; } } @@ -714,6 +715,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState if (!unlinked) { Slog.w(TAG, "unlinking vulture from death failed for " + mActivityToken); } + mClientVulture = null; } }