From 046bfa0c091727e7dbd4445ea5cf732841e239e3 Mon Sep 17 00:00:00 2001 From: Edgar Arriaga Date: Fri, 6 Jan 2023 00:45:33 +0000 Subject: [PATCH] Avoid forced compactions from sending stats This is because forced compactions do not need to pollute our metrics and they would allow compacting things that we usually would not allow they are used either for debugging or for lab testing. Bug: 264598052 Change-Id: I1ddad48aa02b72afacfdedd8bb54feb9d48f41a6 --- .../core/java/com/android/server/am/CachedAppOptimizer.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/am/CachedAppOptimizer.java b/services/core/java/com/android/server/am/CachedAppOptimizer.java index 4c10d58bef2ca..f54e2b06cc9aa 100644 --- a/services/core/java/com/android/server/am/CachedAppOptimizer.java +++ b/services/core/java/com/android/server/am/CachedAppOptimizer.java @@ -1860,7 +1860,10 @@ public final class CachedAppOptimizer { mLastCompactionStats.remove(pid); mLastCompactionStats.put(pid, memStats); mCompactionStatsHistory.add(memStats); - memStats.sendStat(); + if (!forceCompaction) { + // Avoid polluting field metrics with forced compactions. + memStats.sendStat(); + } break; default: // We likely missed adding this category, it needs to be added