From 045abe73e2d61700dda3c6655ca2be75df8e9641 Mon Sep 17 00:00:00 2001
From: Alan Viverette
Date: Fri, 16 Feb 2018 12:22:47 -0500
Subject: [PATCH] Align Theme, Theme.Holo, and Theme.Holo.Light with Material
attrs
Due to themes always overlaying, legacy and Holo themes must explicitly
define Material attributes as @null (e.g. unset).
Deprecates Holo themes. Nobody should be using these anymore.
Bug: 72203192
Test: CtsThemeHostTests & manual verification of bug
Change-Id: I65e9ceddc7aec54b1b8df0231f0755cbd5529886
---
api/current.txt | 56 ++--
core/res/res/values/themes.xml | 65 +++--
core/res/res/values/themes_holo.xml | 323 +++++++++++++++++-------
core/res/res/values/themes_material.xml | 1 -
4 files changed, 296 insertions(+), 149 deletions(-)
diff --git a/api/current.txt b/api/current.txt
index 3edd2c08bcf31..bdb8f5600c798 100644
--- a/api/current.txt
+++ b/api/current.txt
@@ -2215,34 +2215,34 @@ package android {
field public static final int Theme_DeviceDefault_Wallpaper = 16974140; // 0x103013c
field public static final int Theme_DeviceDefault_Wallpaper_NoTitleBar = 16974141; // 0x103013d
field public static final int Theme_Dialog = 16973835; // 0x103000b
- field public static final int Theme_Holo = 16973931; // 0x103006b
- field public static final int Theme_Holo_Dialog = 16973935; // 0x103006f
- field public static final int Theme_Holo_DialogWhenLarge = 16973943; // 0x1030077
- field public static final int Theme_Holo_DialogWhenLarge_NoActionBar = 16973944; // 0x1030078
- field public static final int Theme_Holo_Dialog_MinWidth = 16973936; // 0x1030070
- field public static final int Theme_Holo_Dialog_NoActionBar = 16973937; // 0x1030071
- field public static final int Theme_Holo_Dialog_NoActionBar_MinWidth = 16973938; // 0x1030072
- field public static final int Theme_Holo_InputMethod = 16973951; // 0x103007f
- field public static final int Theme_Holo_Light = 16973934; // 0x103006e
- field public static final int Theme_Holo_Light_DarkActionBar = 16974105; // 0x1030119
- field public static final int Theme_Holo_Light_Dialog = 16973939; // 0x1030073
- field public static final int Theme_Holo_Light_DialogWhenLarge = 16973945; // 0x1030079
- field public static final int Theme_Holo_Light_DialogWhenLarge_NoActionBar = 16973946; // 0x103007a
- field public static final int Theme_Holo_Light_Dialog_MinWidth = 16973940; // 0x1030074
- field public static final int Theme_Holo_Light_Dialog_NoActionBar = 16973941; // 0x1030075
- field public static final int Theme_Holo_Light_Dialog_NoActionBar_MinWidth = 16973942; // 0x1030076
- field public static final int Theme_Holo_Light_NoActionBar = 16974064; // 0x10300f0
- field public static final int Theme_Holo_Light_NoActionBar_Fullscreen = 16974065; // 0x10300f1
- field public static final int Theme_Holo_Light_NoActionBar_Overscan = 16974302; // 0x10301de
- field public static final int Theme_Holo_Light_NoActionBar_TranslucentDecor = 16974306; // 0x10301e2
- field public static final int Theme_Holo_Light_Panel = 16973948; // 0x103007c
- field public static final int Theme_Holo_NoActionBar = 16973932; // 0x103006c
- field public static final int Theme_Holo_NoActionBar_Fullscreen = 16973933; // 0x103006d
- field public static final int Theme_Holo_NoActionBar_Overscan = 16974301; // 0x10301dd
- field public static final int Theme_Holo_NoActionBar_TranslucentDecor = 16974305; // 0x10301e1
- field public static final int Theme_Holo_Panel = 16973947; // 0x103007b
- field public static final int Theme_Holo_Wallpaper = 16973949; // 0x103007d
- field public static final int Theme_Holo_Wallpaper_NoTitleBar = 16973950; // 0x103007e
+ field public static final deprecated int Theme_Holo = 16973931; // 0x103006b
+ field public static final deprecated int Theme_Holo_Dialog = 16973935; // 0x103006f
+ field public static final deprecated int Theme_Holo_DialogWhenLarge = 16973943; // 0x1030077
+ field public static final deprecated int Theme_Holo_DialogWhenLarge_NoActionBar = 16973944; // 0x1030078
+ field public static final deprecated int Theme_Holo_Dialog_MinWidth = 16973936; // 0x1030070
+ field public static final deprecated int Theme_Holo_Dialog_NoActionBar = 16973937; // 0x1030071
+ field public static final deprecated int Theme_Holo_Dialog_NoActionBar_MinWidth = 16973938; // 0x1030072
+ field public static final deprecated int Theme_Holo_InputMethod = 16973951; // 0x103007f
+ field public static final deprecated int Theme_Holo_Light = 16973934; // 0x103006e
+ field public static final deprecated int Theme_Holo_Light_DarkActionBar = 16974105; // 0x1030119
+ field public static final deprecated int Theme_Holo_Light_Dialog = 16973939; // 0x1030073
+ field public static final deprecated int Theme_Holo_Light_DialogWhenLarge = 16973945; // 0x1030079
+ field public static final deprecated int Theme_Holo_Light_DialogWhenLarge_NoActionBar = 16973946; // 0x103007a
+ field public static final deprecated int Theme_Holo_Light_Dialog_MinWidth = 16973940; // 0x1030074
+ field public static final deprecated int Theme_Holo_Light_Dialog_NoActionBar = 16973941; // 0x1030075
+ field public static final deprecated int Theme_Holo_Light_Dialog_NoActionBar_MinWidth = 16973942; // 0x1030076
+ field public static final deprecated int Theme_Holo_Light_NoActionBar = 16974064; // 0x10300f0
+ field public static final deprecated int Theme_Holo_Light_NoActionBar_Fullscreen = 16974065; // 0x10300f1
+ field public static final deprecated int Theme_Holo_Light_NoActionBar_Overscan = 16974302; // 0x10301de
+ field public static final deprecated int Theme_Holo_Light_NoActionBar_TranslucentDecor = 16974306; // 0x10301e2
+ field public static final deprecated int Theme_Holo_Light_Panel = 16973948; // 0x103007c
+ field public static final deprecated int Theme_Holo_NoActionBar = 16973932; // 0x103006c
+ field public static final deprecated int Theme_Holo_NoActionBar_Fullscreen = 16973933; // 0x103006d
+ field public static final deprecated int Theme_Holo_NoActionBar_Overscan = 16974301; // 0x10301dd
+ field public static final deprecated int Theme_Holo_NoActionBar_TranslucentDecor = 16974305; // 0x10301e1
+ field public static final deprecated int Theme_Holo_Panel = 16973947; // 0x103007b
+ field public static final deprecated int Theme_Holo_Wallpaper = 16973949; // 0x103007d
+ field public static final deprecated int Theme_Holo_Wallpaper_NoTitleBar = 16973950; // 0x103007e
field public static final int Theme_InputMethod = 16973908; // 0x1030054
field public static final int Theme_Light = 16973836; // 0x103000c
field public static final int Theme_Light_NoTitleBar = 16973837; // 0x103000d
diff --git a/core/res/res/values/themes.xml b/core/res/res/values/themes.xml
index 9c3d8ebfa5054..3e93a1918dd71 100644
--- a/core/res/res/values/themes.xml
+++ b/core/res/res/values/themes.xml
@@ -41,58 +41,44 @@ please see themes_device_defaults.xml.
#Theme_Holo} or {@link #Theme_DeviceDefault}.
-->
+ UI style also includes a full action bar by default.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
+ the light content.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
-
+
-
+
+ a regular dialog.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
-
+
+ a regular dialog.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
-
+
-
+
+ a regular dialog.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
-
+
+ a regular dialog.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
-
+
-
+
+ wallpaper appear behind them and without an action bar.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
@@ -1073,7 +1203,9 @@ please see themes_device_defaults.xml.
+ background, and turns off dimming behind the window.
+
+ @deprecated Use Material themes on API 21+ or AppCompat on supported APIs. -->
-
+
+
+
+