From 6013e5cc961b64c7cbddb59dbef9fb249d364e9e Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Wed, 18 Apr 2018 08:43:34 -0400 Subject: [PATCH] Color and text changes Change-Id: I2b1837ffd16911be20b5d5f9a7007ff3071265ab Fixes: 78191129 Fixes: 77810424 Fixes: 78196346 Test: manual inspection --- core/java/android/app/Notification.java | 7 ++++--- packages/SystemUI/res/layout/volume_dialog.xml | 2 +- packages/SystemUI/res/values/strings.xml | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/core/java/android/app/Notification.java b/core/java/android/app/Notification.java index 8ee443b47b1a9..22da924d1b8f9 100644 --- a/core/java/android/app/Notification.java +++ b/core/java/android/app/Notification.java @@ -4574,13 +4574,14 @@ public class Notification implements Parcelable bindHeaderChronometerAndTime(contentView); bindProfileBadge(contentView); } - bindActivePermissions(contentView); + bindActivePermissions(contentView, ambient); bindExpandButton(contentView); mN.mUsesStandardHeader = true; } - private void bindActivePermissions(RemoteViews contentView) { - int color = isColorized() ? getPrimaryTextColor() : getSecondaryTextColor(); + private void bindActivePermissions(RemoteViews contentView, boolean ambient) { + int color = ambient ? resolveAmbientColor() + : isColorized() ? getPrimaryTextColor() : resolveContrastColor(); contentView.setDrawableTint(R.id.camera, false, color, PorterDuff.Mode.SRC_ATOP); contentView.setDrawableTint(R.id.mic, false, color, PorterDuff.Mode.SRC_ATOP); contentView.setDrawableTint(R.id.overlay, false, color, PorterDuff.Mode.SRC_ATOP); diff --git a/packages/SystemUI/res/layout/volume_dialog.xml b/packages/SystemUI/res/layout/volume_dialog.xml index dc4e255f650e6..f6c2eebbab66b 100644 --- a/packages/SystemUI/res/layout/volume_dialog.xml +++ b/packages/SystemUI/res/layout/volume_dialog.xml @@ -87,7 +87,7 @@ android:layout_gravity="center" android:contentDescription="@string/accessibility_volume_settings" android:background="@drawable/ripple_drawable_20dp" - android:tint="?android:attr/colorControlNormal" + android:tint="?android:attr/textColorHint" android:soundEffectsEnabled="false" /> diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml index 090d012af72cb..ae40db0f2d53c 100644 --- a/packages/SystemUI/res/values/strings.xml +++ b/packages/SystemUI/res/values/strings.xml @@ -1586,7 +1586,7 @@ Settings - Ok + OK