From 03a73cd40f2ddc8e0abe3d691a9873f4c0f5a3a0 Mon Sep 17 00:00:00 2001 From: Kweku Adams Date: Fri, 30 Mar 2018 16:42:13 -0700 Subject: [PATCH] Disabling print dumping for now. Also updating privacy tags. Bug: 72570451 Bug: 74975371 Test: Android builds Change-Id: Ia1e6a5d0f5e4f141154fc5346bff432149c9123e --- core/proto/android/os/incident.proto | 2 +- core/proto/android/service/print.proto | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/core/proto/android/os/incident.proto b/core/proto/android/os/incident.proto index ea0b825b01a80..6467976bbf592 100644 --- a/core/proto/android/os/incident.proto +++ b/core/proto/android/os/incident.proto @@ -228,7 +228,7 @@ message IncidentProto { ]; optional android.service.print.PrintServiceDumpProto print = 3010 [ - (section).type = SECTION_DUMPSYS, + (section).type = SECTION_NONE, // Turn off until we get approval for it. (section).args = "print --proto" ]; diff --git a/core/proto/android/service/print.proto b/core/proto/android/service/print.proto index f783b866c0acd..994814b6053bf 100644 --- a/core/proto/android/service/print.proto +++ b/core/proto/android/service/print.proto @@ -75,7 +75,7 @@ message PrintSpoolerInternalStateProto { repeated PrintJobInfoProto print_jobs = 1; // Files used by these print jobs - repeated string print_job_files = 2; + repeated string print_job_files = 2 [ (android.privacy).dest = DEST_EXPLICIT ]; // Approved print services repeated android.content.ComponentNameProto approved_services = 3; @@ -101,7 +101,7 @@ message PrinterCapabilitiesProto { } message PrinterInfoProto { - option (android.msg_privacy).dest = DEST_AUTOMATIC; + option (android.msg_privacy).dest = DEST_EXPLICIT; // The id of the printer optional PrinterIdProto id = 1; @@ -123,7 +123,7 @@ message PrinterInfoProto { STATUS_UNAVAILABLE = 3; } // The status of the printer - optional Status status = 3; + optional Status status = 3 [ (android.privacy).dest = DEST_AUTOMATIC ]; // The description of the printer optional string description = 4; @@ -171,13 +171,13 @@ message InstalledPrintServiceProto { } message PrinterIdProto { - option (android.msg_privacy).dest = DEST_AUTOMATIC; + option (android.msg_privacy).dest = DEST_EXPLICIT; // Component name of the service that reported the printer - optional android.content.ComponentNameProto service_name = 1; + optional android.content.ComponentNameProto service_name = 1 [ (android.privacy).dest = DEST_AUTOMATIC ]; // Local id of the printer - optional string local_id = 2 [ (android.privacy).dest = DEST_EXPLICIT ]; + optional string local_id = 2; } message ActivePrintServiceProto { @@ -331,7 +331,7 @@ message PrintJobInfoProto { optional string label = 1 [ (android.privacy).dest = DEST_EXPLICIT ]; // Id of the job - optional string print_job_id = 2; + optional string print_job_id = 2 [ (android.privacy).dest = DEST_EXPLICIT ]; enum State { // Unknown state @@ -366,7 +366,7 @@ message PrintJobInfoProto { optional PrinterIdProto printer = 4; // Tag assigned to the job - optional string tag = 5; + optional string tag = 5 [ (android.privacy).dest = DEST_EXPLICIT ]; // Time the job was created optional int64 creation_time = 6; @@ -401,4 +401,4 @@ message CachedPrintJobProto { // The print job optional PrintJobInfoProto print_job = 2; -} \ No newline at end of file +}