From bdf11af5008a4fb4b775d0e1716b42e1aa25f5e1 Mon Sep 17 00:00:00 2001 From: Joanne Chung Date: Mon, 23 Mar 2020 13:01:03 +0800 Subject: [PATCH] Fix IInlineSuggestionUiCallback not released. In our case, PARCELABLE_WRITE_RETURN_VALUE flag isn't present in writeToParcel, the SurfaceControl.release() will not be called. We should call SurfacePackage.release() after writeToParcel. Bug: 149591513 Test: atest and then does not see the log. Change-Id: Ia11f70b983acee51a9e9c85f3ff966a8404f93e8 --- .../com/android/server/autofill/ui/InlineSuggestionFactory.java | 1 + 1 file changed, 1 insertion(+) diff --git a/services/autofill/java/com/android/server/autofill/ui/InlineSuggestionFactory.java b/services/autofill/java/com/android/server/autofill/ui/InlineSuggestionFactory.java index c26d7eea8351d..8383aae0d5384 100644 --- a/services/autofill/java/com/android/server/autofill/ui/InlineSuggestionFactory.java +++ b/services/autofill/java/com/android/server/autofill/ui/InlineSuggestionFactory.java @@ -302,6 +302,7 @@ public final class InlineSuggestionFactory { public void onContent(SurfaceControlViewHost.SurfacePackage surface) throws RemoteException { callback.onContent(surface); + surface.release(); } @Override