From 3b11892856591058ca605d1b1b46ea45b577621d Mon Sep 17 00:00:00 2001 From: Jean-Michel Trivi Date: Thu, 5 May 2016 18:01:56 -0700 Subject: [PATCH] Fix javadoc missing possible return value in AudioRecordingConfiguration Bug 28623134 Change-Id: I342121cc82bbee3e9b3373db0d70a08eb781eedf --- .../android/media/AudioRecordingConfiguration.java | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/media/java/android/media/AudioRecordingConfiguration.java b/media/java/android/media/AudioRecordingConfiguration.java index cd6f95acda5fa..593516639e29a 100644 --- a/media/java/android/media/AudioRecordingConfiguration.java +++ b/media/java/android/media/AudioRecordingConfiguration.java @@ -56,28 +56,35 @@ public final class AudioRecordingConfiguration implements Parcelable { mPatchHandle = patchHandle; } + // matches the sources that return false in MediaRecorder.isSystemOnlyAudioSource(source) /** @hide */ @IntDef({ MediaRecorder.AudioSource.DEFAULT, + MediaRecorder.AudioSource.MIC, MediaRecorder.AudioSource.VOICE_UPLINK, MediaRecorder.AudioSource.VOICE_DOWNLINK, MediaRecorder.AudioSource.VOICE_CALL, MediaRecorder.AudioSource.CAMCORDER, MediaRecorder.AudioSource.VOICE_RECOGNITION, - MediaRecorder.AudioSource.VOICE_COMMUNICATION + MediaRecorder.AudioSource.VOICE_COMMUNICATION, + MediaRecorder.AudioSource.UNPROCESSED }) @Retention(RetentionPolicy.SOURCE) public @interface AudioSource {} + // documented return values match the sources that return false + // in MediaRecorder.isSystemOnlyAudioSource(source) /** * Returns the audio source being used for the recording. - * @return one of {@link MediaRecorder.AudioSource#MIC}, + * @return one of {@link MediaRecorder.AudioSource#DEFAULT}, + * {@link MediaRecorder.AudioSource#MIC}, * {@link MediaRecorder.AudioSource#VOICE_UPLINK}, * {@link MediaRecorder.AudioSource#VOICE_DOWNLINK}, * {@link MediaRecorder.AudioSource#VOICE_CALL}, * {@link MediaRecorder.AudioSource#CAMCORDER}, * {@link MediaRecorder.AudioSource#VOICE_RECOGNITION}, - * {@link MediaRecorder.AudioSource#VOICE_COMMUNICATION}. + * {@link MediaRecorder.AudioSource#VOICE_COMMUNICATION}, + * {@link MediaRecorder.AudioSource#UNPROCESSED}. */ public @AudioSource int getClientAudioSource() { return mClientSource; }