From 057c908ef48c96b79b727e28e6ac2a82eeca6dc7 Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Mon, 6 Jun 2022 19:12:34 +0000 Subject: [PATCH] UserManagerService: fix comment for mRemovingUserIds Correctly describe the purpose of mRemovingUserIds. Bug: 234059731 Change-Id: I51f6b25469762304f747645521f77a7883944a05 --- .../java/com/android/server/pm/UserManagerService.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/services/core/java/com/android/server/pm/UserManagerService.java b/services/core/java/com/android/server/pm/UserManagerService.java index be7e2dadc7acb..374a5c266108a 100644 --- a/services/core/java/com/android/server/pm/UserManagerService.java +++ b/services/core/java/com/android/server/pm/UserManagerService.java @@ -407,9 +407,12 @@ public class UserManagerService extends IUserManager.Stub { private final Bundle mGuestRestrictions = new Bundle(); /** - * Set of user IDs being actively removed. Removed IDs linger in this set - * for several seconds to work around a VFS caching issue. - * Use {@link #addRemovingUserIdLocked(int)} to add elements to this array + * Set of user IDs that are being removed or were removed during the current boot. User IDs in + * this set aren't reused until the device is rebooted, unless MAX_USER_ID is reached. Some + * services don't fully clear out in-memory user state upon user removal; this behavior is + * intended to mitigate such issues by limiting user ID reuse. This array applies to any type + * of user (including pre-created users) when they are removed. Use {@link + * #addRemovingUserIdLocked(int)} to add elements to this array. */ @GuardedBy("mUsersLock") private final SparseBooleanArray mRemovingUserIds = new SparseBooleanArray();