Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "camera: Fix exception handling from ImageReader#detach" into tm-d1-dev

Browse Source
This commit is contained in:
Avichal Rakesh
2022-07-07 22:14:03 +00:00
committed by Android (Google) Code Review
parent f2cf01bb57 a9d512bef1
commit 00d8fb5022
1 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
core/java/android/hardware/camera2/impl/CameraExtensionSessionImpl.java
View File

@@ -1737,6 +1737,20 @@ public final class CameraExtensionSessionImpl extends CameraExtensionSession {
} catch (IllegalStateException e) { } catch (IllegalStateException e) {
// This is possible in case the client disconnects from the output surface // This is possible in case the client disconnects from the output surface
// abruptly. // abruptly.
Log.w(TAG, "Output surface likely abandoned, dropping buffer!");
img.close();
} catch (RuntimeException e) {
// NOTE: This is intended to catch RuntimeException from ImageReader.detachImage
// ImageReader.detachImage is not supposed to throw RuntimeExceptions but the
// bug went unchecked for a few years and now its behavior cannot be changed
// without breaking backwards compatibility.
if (!e.getClass().equals(RuntimeException.class)) {
// re-throw any exceptions that aren't base RuntimeException since they are
// coming from elsewhere, and we shouldn't silently drop those.
throw e;
}
Log.w(TAG, "Output surface likely abandoned, dropping buffer!"); Log.w(TAG, "Output surface likely abandoned, dropping buffer!");
img.close(); img.close();
} }
@@ -1773,9 +1787,23 @@ public final class CameraExtensionSessionImpl extends CameraExtensionSession {
} }
try { try {
reader.detachImage(img); reader.detachImage(img);
} catch (Exception e) { } catch (IllegalStateException e) {
Log.e(TAG, Log.e(TAG, "Failed to detach image!");
"Failed to detach image!"); img.close();
return;
} catch (RuntimeException e) {
// NOTE: This is intended to catch RuntimeException from ImageReader.detachImage
// ImageReader.detachImage is not supposed to throw RuntimeExceptions but the
// bug went unchecked for a few years and now its behavior cannot be changed
// without breaking backwards compatibility.
if (!e.getClass().equals(RuntimeException.class)) {
// re-throw any exceptions that aren't base RuntimeException since they are
// coming from elsewhere, and we shouldn't silently drop those.
throw e;
}
Log.e(TAG, "Failed to detach image!");
img.close(); img.close();
return; return;
} }