Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Camera: Avoid possible deadlock when closing advanced extension session" into sc-qpr1-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2021-10-08 19:49:12 +00:00
committed by Android (Google) Code Review
parent 7cb452002e dd55b3dee5
commit 00c890cda7
1 changed files with 34 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
core/java/android/hardware/camera2/impl/CameraAdvancedExtensionSessionImpl.java
View File

@@ -873,21 +873,19 @@ public final class CameraAdvancedExtensionSessionImpl extends CameraExtensionSes
@Override @Override
public int submitBurst(List<Request> requests, IRequestCallback callback) { public int submitBurst(List<Request> requests, IRequestCallback callback) {
int seqId = -1; int seqId = -1;
synchronized (mInterfaceLock) { try {
try { CaptureCallbackHandler captureCallback = new CaptureCallbackHandler(callback);
CaptureCallbackHandler captureCallback = new CaptureCallbackHandler(callback); ArrayList<CaptureRequest> captureRequests = new ArrayList<>();
ArrayList<CaptureRequest> captureRequests = new ArrayList<>(); for (Request request : requests) {
for (Request request : requests) { captureRequests.add(initializeCaptureRequest(mCameraDevice, request,
captureRequests.add(initializeCaptureRequest(mCameraDevice, request, mCameraConfigMap));
mCameraConfigMap));
}
seqId = mCaptureSession.captureBurstRequests(captureRequests,
new CameraExtensionUtils.HandlerExecutor(mHandler), captureCallback);
} catch (CameraAccessException e) {
Log.e(TAG, "Failed to submit capture requests!");
} catch (IllegalStateException e) {
Log.e(TAG, "Capture session closed!");
} }
seqId = mCaptureSession.captureBurstRequests(captureRequests,
new CameraExtensionUtils.HandlerExecutor(mHandler), captureCallback);
} catch (CameraAccessException e) {
Log.e(TAG, "Failed to submit capture requests!");
} catch (IllegalStateException e) {
Log.e(TAG, "Capture session closed!");
} }
return seqId; return seqId;
@@ -896,18 +894,16 @@ public final class CameraAdvancedExtensionSessionImpl extends CameraExtensionSes
@Override @Override
public int setRepeating(Request request, IRequestCallback callback) { public int setRepeating(Request request, IRequestCallback callback) {
int seqId = -1; int seqId = -1;
synchronized (mInterfaceLock) { try {
try { CaptureRequest repeatingRequest = initializeCaptureRequest(mCameraDevice,
CaptureRequest repeatingRequest = initializeCaptureRequest(mCameraDevice, request, mCameraConfigMap);
request, mCameraConfigMap); CaptureCallbackHandler captureCallback = new CaptureCallbackHandler(callback);
CaptureCallbackHandler captureCallback = new CaptureCallbackHandler(callback); seqId = mCaptureSession.setSingleRepeatingRequest(repeatingRequest,
seqId = mCaptureSession.setSingleRepeatingRequest(repeatingRequest, new CameraExtensionUtils.HandlerExecutor(mHandler), captureCallback);
new CameraExtensionUtils.HandlerExecutor(mHandler), captureCallback); } catch (CameraAccessException e) {
} catch (CameraAccessException e) { Log.e(TAG, "Failed to enable repeating request!");
Log.e(TAG, "Failed to enable repeating request!"); } catch (IllegalStateException e) {
} catch (IllegalStateException e) { Log.e(TAG, "Capture session closed!");
Log.e(TAG, "Capture session closed!");
}
} }
return seqId; return seqId;
@@ -915,27 +911,23 @@ public final class CameraAdvancedExtensionSessionImpl extends CameraExtensionSes
@Override @Override
public void abortCaptures() { public void abortCaptures() {
synchronized (mInterfaceLock) { try {
try { mCaptureSession.abortCaptures();
mCaptureSession.abortCaptures(); } catch (CameraAccessException e) {
} catch (CameraAccessException e) { Log.e(TAG, "Failed during capture abort!");
Log.e(TAG, "Failed during capture abort!"); } catch (IllegalStateException e) {
} catch (IllegalStateException e) { Log.e(TAG, "Capture session closed!");
Log.e(TAG, "Capture session closed!");
}
} }
} }
@Override @Override
public void stopRepeating() { public void stopRepeating() {
synchronized (mInterfaceLock) { try {
try { mCaptureSession.stopRepeating();
mCaptureSession.stopRepeating(); } catch (CameraAccessException e) {
} catch (CameraAccessException e) { Log.e(TAG, "Failed during repeating capture stop!");
Log.e(TAG, "Failed during repeating capture stop!"); } catch (IllegalStateException e) {
} catch (IllegalStateException e) { Log.e(TAG, "Capture session closed!");
Log.e(TAG, "Capture session closed!");
}
} }
} }
} }