From 004d45a945382aa39432b4c1866f1b21840116f0 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Mon, 10 Feb 2020 14:19:42 -0500 Subject: [PATCH] Delete files properly when history disabled Delete the files, then the directory Test: turn history off, check folder on device Bug: 137396965 Change-Id: Ic69adf6d08219cab186c131147192f5d1ea1ee91 --- .../server/notification/NotificationHistoryDatabase.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/services/core/java/com/android/server/notification/NotificationHistoryDatabase.java b/services/core/java/com/android/server/notification/NotificationHistoryDatabase.java index 061cbd8a1a402..dc61fb01a246e 100644 --- a/services/core/java/com/android/server/notification/NotificationHistoryDatabase.java +++ b/services/core/java/com/android/server/notification/NotificationHistoryDatabase.java @@ -231,6 +231,9 @@ public class NotificationHistoryDatabase { public void disableHistory() { synchronized (mLock) { + for (AtomicFile file : mHistoryFiles) { + file.delete(); + } mHistoryDir.delete(); mHistoryFiles.clear(); } @@ -249,6 +252,10 @@ public class NotificationHistoryDatabase { final AtomicFile currentOldestFile = mHistoryFiles.get(i); final long creationTime = mFileAttrProvider.getCreationTime(currentOldestFile.getBaseFile()); + if (DEBUG) { + Slog.d(TAG, "Pruning " + currentOldestFile.getBaseFile().getName() + + " created on " + creationTime); + } if (creationTime <= retentionBoundary.getTimeInMillis()) { if (DEBUG) { Slog.d(TAG, "Removed " + currentOldestFile.getBaseFile().getName());