From 00413cee439259a56eb7c649e884d570ec634c02 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Fri, 21 Dec 2018 11:22:30 -0500 Subject: [PATCH] Remove Dependency.get usages from GarbageMonitor Test: atest SystemUITests Change-Id: Ic3631b6ef49c43a3d31a393a82a287bc71be8e87 --- .../SystemUI/src/com/android/systemui/SystemUIFactory.java | 4 ++++ .../src/com/android/systemui/util/leak/GarbageMonitor.java | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/SystemUIFactory.java b/packages/SystemUI/src/com/android/systemui/SystemUIFactory.java index 8bac7c590249b..b3e2cffba4fb0 100644 --- a/packages/SystemUI/src/com/android/systemui/SystemUIFactory.java +++ b/packages/SystemUI/src/com/android/systemui/SystemUIFactory.java @@ -56,6 +56,7 @@ import com.android.systemui.statusbar.phone.StatusBarIconController; import com.android.systemui.statusbar.phone.StatusBarKeyguardViewManager; import com.android.systemui.statusbar.policy.DeviceProvisionedController; import com.android.systemui.util.InjectionInflationController; +import com.android.systemui.util.leak.GarbageMonitor; import com.android.systemui.volume.VolumeDialogComponent; import java.util.function.Consumer; @@ -237,5 +238,8 @@ public class SystemUIFactory { * ViewCreator generates all Views that need injection. */ InjectionInflationController.ViewCreator createViewCreator(); + + @Singleton + GarbageMonitor createGarbageMonitor(); } } diff --git a/packages/SystemUI/src/com/android/systemui/util/leak/GarbageMonitor.java b/packages/SystemUI/src/com/android/systemui/util/leak/GarbageMonitor.java index 7bc96261782d2..0328c7b0fb84c 100644 --- a/packages/SystemUI/src/com/android/systemui/util/leak/GarbageMonitor.java +++ b/packages/SystemUI/src/com/android/systemui/util/leak/GarbageMonitor.java @@ -43,9 +43,9 @@ import android.text.format.DateUtils; import android.util.Log; import android.util.LongSparseArray; -import com.android.systemui.Dependency; import com.android.systemui.R; import com.android.systemui.SystemUI; +import com.android.systemui.SystemUIFactory; import com.android.systemui.plugins.qs.QSTile; import com.android.systemui.qs.QSHost; import com.android.systemui.qs.tileimpl.QSTileImpl; @@ -348,7 +348,7 @@ public class GarbageMonitor { public MemoryTile(QSHost host) { super(host); - gm = Dependency.get(GarbageMonitor.class); + gm = SystemUIFactory.getInstance().getRootComponent().createGarbageMonitor(); } @Override @@ -453,7 +453,8 @@ public class GarbageMonitor { Settings.Secure.getInt( mContext.getContentResolver(), FORCE_ENABLE_LEAK_REPORTING, 0) != 0; - mGarbageMonitor = Dependency.get(GarbageMonitor.class); + mGarbageMonitor = SystemUIFactory.getInstance().getRootComponent() + .createGarbageMonitor(); if (LEAK_REPORTING_ENABLED || forceEnable) { mGarbageMonitor.startLeakMonitor(); }